[mlir] Fix build after #116470 #118147
Merged
[mlir] Fix build after #116470 #118147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-flang-fir-hlfir @llvm/pr-subscribers-mlir Author: Matthias Springer (matthias-springer) ChangesFull diff: https://github.com/llvm/llvm-project/pull/118147.diff 1 Files Affected:
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index 613fd6d9d74b1f..687bf625d457a5 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -1204,7 +1204,8 @@ LogicalResult ConversionPatternRewriterImpl::remapValues(
// TODO: This is a 1:N conversion. The conversion value mapping does not
// store such materializations yet. If the types of the most recently
// mapped values do not match, build a target materialization.
- if (TypeRange(unpacked) == legalTypes) {
+ ValueRange unpackedRange(unpacked);
+ if (TypeRange(unpackedRange) == legalTypes) {
remapped.push_back(std::move(unpacked));
continue;
}
|
Member
|
@llvm/pr-subscribers-mlir-core Author: Matthias Springer (matthias-springer) ChangesFull diff: https://github.com/llvm/llvm-project/pull/118147.diff 1 Files Affected:
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index 613fd6d9d74b1f..687bf625d457a5 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -1204,7 +1204,8 @@ LogicalResult ConversionPatternRewriterImpl::remapValues(
// TODO: This is a 1:N conversion. The conversion value mapping does not
// store such materializations yet. If the types of the most recently
// mapped values do not match, build a target materialization.
- if (TypeRange(unpacked) == legalTypes) {
+ ValueRange unpackedRange(unpacked);
+ if (TypeRange(unpackedRange) == legalTypes) {
remapped.push_back(std::move(unpacked));
continue;
}
|
matthias-springer
force-pushed
the
users/matthias-springer/fix_build_30
branch
from
5a5f20e to
7ba2921
Compare
llvmbot
added
flang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been part of #116470.